[Bug 731791] videometa: add GstVideoAffineTransformationMeta

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=731791

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #315115|needs-work                  |none
             status|                            |
 Attachment #315115|0                           |1
        is obsolete|                            |

--- Comment #8 from Matthew Waters <ystreet00 at gmail.com> ---
Created attachment 315167
  --> https://bugzilla.gnome.org/attachment.cgi?id=315167&action=edit
video: add GstVideoAffineTransformationMeta

Addressed review comments.

(In reply to Sebastian Dröge (slomo) from comment #7)
> Review of attachment 315115 [details] [review]:
> @@ +99,3 @@
> + * @buffer: a #GstBuffer
> + * @matrix: a 4x4 transformation matrix
> + * @get_matrix: a custom get_matrix function to be used by the
> 
> This functions has no matrix and get_matrix parameters. Why doesn't it have
> a matrix parameter? :)

It's slightly simpler without the matrix parameter and the use case I have does
not have the matrix when the meta needs to be added to the buffer.  If you want
we can always add it later in a _full() variant.

The same functionality can always be achieved with meta = add_meta();
apply_matrix (meta, matrix).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.