[Bug 733959] hlsdemux: download bitrate algorithms don't reflect real download rate

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=733959

--- Comment #50 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
> Thanks! I suppose these patches can't be merged in 1.6
> because of the queue2 signal/property, right?

Probably not, though it's possible, both are not very intrusive code-wise. Not
sure about the adaptivedemux changes. The extra "up to 20MB" memory requirement
introduced by the new queue seems quite hefty though, so that's perhaps not
something we should pick into the stable branch.

I'm also not entirely happy about the new "overrun" property because that now
basically imposes a non-trivial performance penalty in the main code path for
everyone using the element even if the signal is not used. For the sole reason
of printing a GST_WARNING debug log message in adaptivedemux! I wonder if you
couldn't have just used the messages it posts by overriding the
GstBin::handle_message() vfunc in adaptivedemux and dropping it there.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.