[Bug 743345] glupload: Add support for dmabuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743345

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316107|none                        |needs-work
             status|                            |

--- Comment #54 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 316107:
 --> (https://bugzilla.gnome.org/review?bug=743345&attachment=316107)

Some comments.

::: gst-libs/gst/gl/egl/gsteglimagememory.c
@@ +383,3 @@
+  attribs[atti++] = GST_VIDEO_INFO_PLANE_OFFSET (in_info, plane);
+  attribs[atti++] = EGL_DMA_BUF_PLANE0_PITCH_EXT;
+  attribs[atti++] = GST_VIDEO_INFO_PLANE_STRIDE (in_info, plane);

What about multi-planar video? Wouldn't you need PLANE1/2 here instead for
them?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.