[Bug 743345] glupload: Add support for dmabuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743345

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316108|none                        |needs-work
             status|                            |

--- Comment #55 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 316108:
 --> (https://bugzilla.gnome.org/review?bug=743345&attachment=316108)

Some comments

::: gst-libs/gst/gl/gstglupload.c
@@ +524,3 @@
+GST_STATIC_CAPS (GST_VIDEO_CAPS_MAKE_WITH_FEATURES
+    ("memory:" GST_ALLOCATOR_DMABUF,
+        "{ ABGR, ARGB, BGRA, BGRx, RGB16, RGBA, RGBx, xBGR, xRGB }"));

The example pipeline in the blurb won't work with this template.  There are no
YUV formats here so format=NV12 is using the raw uploader which means nothing
has changed.

@@ +592,3 @@
+      gst_buffer_ref (buffer);
+      gst_mini_object_set_qdata ((GstMiniObject *) image->outbuf,
+          quark, buffer, (GDestroyNotify) gst_buffer_unref);

Perhaps the GstParentBufferMeta would work better than setting some qdata.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.