[Bug 758384] dashdemux: tests: refactor into adaptive_engine components

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Nov 24 07:32:40 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=758384

--- Comment #9 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 315946:
 --> (https://bugzilla.gnome.org/review?bug=758384&attachment=315946)

::: tests/check/elements/adaptive_demux_common.c
@@ +171,3 @@
+  if (testOutputStreamData->expected_data) {
+    gsize size = gst_buffer_get_size (buffer);
+    fail_unless ((streamOffset + size) <=
testOutputStreamData->expected_size);

Not sure I understand this.

What happens if you would seek to byte=100 and was only expecting to receive 10
bytes after it.

What would expected_size contain in this case and how streamOffset + size can
be smaller than the expected size?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list