[Bug 758384] dashdemux: tests: refactor into adaptive_engine components

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758384

--- Comment #10 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
Review of attachment 315946:
 --> (https://bugzilla.gnome.org/review?bug=758384&attachment=315946)

::: tests/check/elements/dash_demux.c
@@ +26,3 @@
+#define COPY_OUTPUT_TEST_DATA(outputTestData,testData) do { \
+  guint otdLen = sizeof((outputTestData)) / sizeof((outputTestData)[0]); \
+    for(guint otdPos=0; otdPos<otdLen; ++otdPos){ \

Gstreamer standard is to declare loop counters out of the loop

@@ +29,3 @@
+  (testData)->output_streams = g_list_append ((testData)->output_streams,
&(outputTestData)[otdPos]); \
+    } \
+  } while(0);

Remove the ; so we don't accidentally get two statements

@@ +257,3 @@
       "      </Representation></AdaptationSet></Period></MPD>";

+  GstDashDemuxTestInputData inputTestData[] = {

Why is const removed ? Is it modified now ? Should also be static. Same for
other test data below.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.