[Bug 750456] rtpsession: Implement sending of reduced size RTCP packets

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750456

Stian Selnes (stianse) <stian.selnes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gstreamer at pexip.com,
                   |                            |stian.selnes at gmail.com

--- Comment #8 from Stian Selnes (stianse) <stian.selnes at gmail.com> ---
The proposed patch seems to fit well with our use of Reduced-Size RTCP also.
Specifically we would like to send non-standard Reduced-Size RTCP Feedback
messages at any time (e.g. MS-RTP) by connecting to 'on-sending-rtcp' and add
the GstRTCPPacket before sending. This should allow for, when early feedback is
requested from the signal 'send-rtcp' and no PLI/FIR/NACKs are pending, that
'on-sending-rtcp' is emitted with an empty buffer so that the GstRTCPPacket can
be added. This seems to be the case with the patch.

In the same scenario if there is no signal handler, does the patch have an
issue where we can end up trying to send an empty buffer?

I have not tested any of this yet in GStreamer 1.x, but will do that in not too
long and try to add some element tests.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.