[Bug 750456] rtpsession: Implement sending of reduced size RTCP packets

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750456

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Stian Selnes (stianse) from comment #8)
> The proposed patch seems to fit well with our use of Reduced-Size RTCP also.

I'll merge it now, waited here long enough :) Patches are not wine

> Specifically we would like to send non-standard Reduced-Size RTCP Feedback
> messages at any time (e.g. MS-RTP) by connecting to 'on-sending-rtcp' and
> add the GstRTCPPacket before sending. This should allow for, when early
> feedback is requested from the signal 'send-rtcp' and no PLI/FIR/NACKs are
> pending, that 'on-sending-rtcp' is emitted with an empty buffer so that the
> GstRTCPPacket can be added. This seems to be the case with the patch.

So that part is ok for you? Great!

> In the same scenario if there is no signal handler, does the patch have an
> issue where we can end up trying to send an empty buffer?

The return value of on-sending-rtcp can be used here. We only send an RTCP
packet if a) it got contents before on-sending-rtcp or b) on-sending-rtcp
returned TRUE.

If there was no content before and on-sending-rtcp returns FALSE, no packet
will be sent.

> I have not tested any of this yet in GStreamer 1.x, but will do that in not
> too long and try to add some element tests.

Let us know how it goes :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.