[Bug 748259] [PATCH] New audio/video level element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748259

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308787|none                        |accepted-commit_now
             status|                            |

--- Comment #26 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> ---
Review of attachment 308787:
 --> (https://bugzilla.gnome.org/review?bug=748259&attachment=308787)

Regarding the tests, up to you.

::: tests/check/elements/videoframe-audiolevel.c
@@ +413,3 @@
+GST_START_TEST (test_videoframe_audiolevel_16chan_1)
+{
+  channels = 16;

If you use a structure for the parameters that you pass to
test_videoframe_audiolevel_generic(), you'll get a warning if there is an
uninitialized member, right now i'd be  worried that in the future another
param is added and not all tests are updated to set it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.