[Bug 748259] [PATCH] New audio/video level element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748259

Vivia Nikolaidou <vivia at ahiru.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308787|accepted-commit_now         |none
             status|                            |
 Attachment #308787|0                           |1
        is obsolete|                            |

--- Comment #27 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Created attachment 313745
  --> https://bugzilla.gnome.org/attachment.cgi?id=313745&action=edit
Updated patch: cleaned up unit tests

Thanks for the comments. Added a set_default_params() function to set all
defaults for the test parameters.

As discussed on IRC, we have many flags, and initializing the struct wouldn't
look very readable:
TestingParams params = {40, 15, 16, 1, 0.0078125, FALSE, FALSE, FALSE, FALSE,
FALSE, FALSE, FALSE, FALSE, FALSE, FALSE};

The set_default_params() function though makes the code much more readable: we
set all parameters to their defaults and initialize only the ones we need
different.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.