[Bug 751792] dashdemux: incorrect segment duration for a segment list

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751792

--- Comment #9 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
There may be something I'm missing, as I'm really unclear about the base all
these durations and timestamps are from, but I think this should be changed in
the unit test:

-  expectedDuration = duration_to_ms (0, 0, 0, 0, 0, 25, 0);
+  expectedDuration = duration_to_ms (0, 0, 0, 0, 0, 20, 0);

This is because the first segment should be clipped (assuming it's meant to
start at the start of the period (which starts at 10) and not at the same time
as the period's time base (10 seconds before)). The comment also says the first
segment is supposed to be 20 seconds:

   * We expect first segment to have a duration of 20 seconds (limited by the
period)

Second, the second segment should have:

-  assert_equals_uint64 (fragment.duration, expectedDuration * GST_MSECOND);
+  assert_equals_uint64 (fragment.duration, 0);

Since it gets completely clipped.
As for its starting point, I'm not sure what it should be, as it's entirely
clipped out.

With those changes, the test passes with my patch (except the second's
segment's start value, which I'm not sure what makes most sense there).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.