[Bug 751792] dashdemux: incorrect segment duration for a segment list

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751792

--- Comment #10 from Florin Apostol <florin.apostol at oregan.net> ---
(In reply to Vincent Penquerc'h from comment #9)
> There may be something I'm missing, as I'm really unclear about the base all
> these durations and timestamps are from, but I think this should be changed
> in the unit test:
> 
> -  expectedDuration = duration_to_ms (0, 0, 0, 0, 0, 25, 0);
> +  expectedDuration = duration_to_ms (0, 0, 0, 0, 0, 20, 0);
> 
> This is because the first segment should be clipped (assuming it's meant to
> start at the start of the period (which starts at 10) and not at the same
> time as the period's time base (10 seconds before)). The comment also says
> the first segment is supposed to be 20 seconds:
> 
>    * We expect first segment to have a duration of 20 seconds (limited by
> the period)
> 
You are correct, the first segment should have a 20ms duration.

> Second, the second segment should have:
> 
> -  assert_equals_uint64 (fragment.duration, expectedDuration * GST_MSECOND);
> +  assert_equals_uint64 (fragment.duration, 0);
> 
> Since it gets completely clipped.
> As for its starting point, I'm not sure what it should be, as it's entirely
> clipped out.

I think the second segment should not exist at all because it is completely
clipped. The test should check that only 1 segment is present. The
implementation should refuse to add segments to list if their start is greater
than period end.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.