[Bug 754826] memory: add remap operation

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754826

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311061|none                        |reviewed
             status|                            |

--- Comment #3 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 311061:
 --> (https://bugzilla.gnome.org/review?bug=754826&attachment=311061)

The whole undo operation feels fishy to me, I'm not sure how a undo is
different from modifying the flags again? Although locking downgrades seem
find, locking upgrades seem like a risky idea. Downgrading and then
re-upgrading seems downright wrong for example as someone else could have
mapped it for reading while that happens and then you won't be able to
re-upgrade!

I'd have a simple
gst_mini_object_downgrade_lock(GstMiniObject, gint flags_to_drop);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.