[Bug 754826] memory: add remap operation

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754826

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311062|none                        |reviewed
             status|                            |

--- Comment #4 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 311062:
 --> (https://bugzilla.gnome.org/review?bug=754826&attachment=311062)

Is this for the problem of gst-ffmpeg pushing down RW mapped buffers or do you
have some other usecase?

::: gst/gstbuffer.c
@@ +1705,3 @@
+gboolean
+gst_buffer_remap (GstBuffer * buffer, GstMapInfo * info, gboolean add,
+    GstMapFlags flags)

Why do you need the buffer here? wouldn't gst_memory_remap(GstMapInfo, add,
flags) be enough?
Is any remapping function but adding or removing the GST_MAP_WRITE ever going
to be useful? Do we need something so generic?

::: gst/gstmemory.c
@@ +348,3 @@
+gboolean
+gst_memory_remap (GstMemory * mem, GstMapInfo * info, gboolean add,
+    GstMapFlags flags)

Why not get the memory from info->memory?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.