[Bug 754465] compositor: Negotiation failure with ARGB64

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754465

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311174|none                        |reviewed
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 311174:
 --> (https://bugzilla.gnome.org/review?bug=754465&attachment=311174)

Generally looks good :)

::: gst-libs/gst/video/gstvideoaggregator.c
@@ +2075,3 @@
   klass->get_output_buffer = gst_videoaggregator_get_output_buffer;

+  g_mutex_init (&klass->sink_caps_mutex);

This is not necessarily a good idea... each subclass will have the mutex
memcpy'd into their own class struct, g_mutex_lock() and friends might in
theory do something with the memory location of the mutex.

Better make this a global mutex, not one stored in the class struct

@@ +2167,3 @@
+  g_mutex_lock (&klass->sink_caps_mutex);
+  if (klass->sink_non_alpha_caps == NULL) {
+    klass->sink_non_alpha_caps = _get_non_alpha_caps_from_template (klass);

Why not a GOnce in the class struct? But sure, this also works :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.