[Bug 754465] compositor: Negotiation failure with ARGB64

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754465

--- Comment #11 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #10)
> Review of attachment 311174 [details] [review]:
> 
> Generally looks good :)
> 
> ::: gst-libs/gst/video/gstvideoaggregator.c
> @@ +2075,3 @@
>    klass->get_output_buffer = gst_videoaggregator_get_output_buffer;
>  
> +  g_mutex_init (&klass->sink_caps_mutex);
> 
> This is not necessarily a good idea... each subclass will have the mutex
> memcpy'd into their own class struct, g_mutex_lock() and friends might in
> theory do something with the memory location of the mutex.
> 
> Better make this a global mutex, not one stored in the class struct
> 
> @@ +2167,3 @@
> +  g_mutex_lock (&klass->sink_caps_mutex);
> +  if (klass->sink_non_alpha_caps == NULL) {
> +    klass->sink_non_alpha_caps = _get_non_alpha_caps_from_template (klass);
> 
> Why not a GOnce in the class struct? But sure, this also works :)

Is a GOnce initialization possible inside a struct? I just saw there was some
macro to initialize it, didn't check if it was 0 by default. I'll check and if
that works I'll change it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.