[Bug 750847] dashdemux: variables containing time information should be guint64 not gint64

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750847

--- Comment #15 from Florin Apostol <florin.apostol at oregan.net> ---
Review of attachment 311467:
 --> (https://bugzilla.gnome.org/review?bug=750847&attachment=311467)

::: ext/dash/gstmpdparser.c
@@ +847,3 @@
+  char *end = NULL;
+
+  if (!g_ascii_isdigit (*s))

I believe this solution will not skip spaces at the beginning of s and will
return -1

Why not use normal sscanf(str, &read) and test that read >= 0 ? This was
proposed in https://bugzilla.gnome.org/show_bug.cgi?id=752429

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.