[Bug 750847] dashdemux: variables containing time information should be guint64 not gint64

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750847

--- Comment #16 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
(In reply to Florin Apostol from comment #15)
> Review of attachment 311467 [details] [review]:
> 
> ::: ext/dash/gstmpdparser.c
> @@ +847,3 @@
> +  char *end = NULL;
> +
> +  if (!g_ascii_isdigit (*s))
> 
> I believe this solution will not skip spaces at the beginning of s and will
> return -1

Indeed. Raw strtoul would allow those.

> Why not use normal sscanf(str, &read) and test that read >= 0 ? This was
> proposed in https://bugzilla.gnome.org/show_bug.cgi?id=752429

Could do as well I guess. Testing here, sscanf will allow leading whitespace,
even if the format string does not contain whitespace.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.