[Bug 752429] dashdemux: negative numbers are successfully read into unsigned variables

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752429

--- Comment #2 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
Review of attachment 307487:
 --> (https://bugzilla.gnome.org/review?bug=752429&attachment=307487)

::: ext/dash/gstmpdparser.c
@@ +261,3 @@
   if (prop_string) {
+    if (sscanf ((gchar *) prop_string, "%u", property_value) &&
+        strstr ((gchar *) prop_string, "-") == NULL) {

minor, but could use strchr since it's a single char

@@ +727,1 @@
       goto error;

Why not valid range ? Same for hours etc below. Assuming no leap seconds.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.