[Bug 752429] dashdemux: negative numbers are successfully read into unsigned variables

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752429

--- Comment #3 from Florin Apostol <florin.apostol at oregan.net> ---
(In reply to Vincent Penquerc'h from comment #2)
> Review of attachment 307487 [details] [review]:
> 
> ::: ext/dash/gstmpdparser.c
> @@ +261,3 @@
>    if (prop_string) {
> +    if (sscanf ((gchar *) prop_string, "%u", property_value) &&
> +        strstr ((gchar *) prop_string, "-") == NULL) {
> 
> minor, but could use strchr since it's a single char
No, because the possibility of spaces at the beginning of the string.

> 
> @@ +727,1 @@
>        goto error;
> 
> Why not valid range ? Same for hours etc below. Assuming no leap seconds.

Because 0 is not a valid value for year, month or day, but it is a valid value
for hour, minute or second.
http://books.xmlschemata.org/relaxng/ch19-77049.html

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.