[Bug 711155] wayland: add wl_drm support to wayland sink

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=711155

--- Comment #57 from Julien Isorce <julien.isorce at gmail.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #56)
> (In reply to Benjamin Gaignard from comment #53)
> Thus, allocators stored in
> the query are expected to implement gst_allocator_alloc() and to allow
> selecting a size and an alignment. This is not the case of the generic
> DMABUF allocator, which does not implement the generic alloc method. So I believe it's wrong to add this allocator there.

I think "gst_query_add_allocation_param" should prevent to add an allocator
which has its GstAllocatorClass->alloc set to NULL. (which is the case for gst
dmabuf alocator, it seems that it has derived to also define it with a
g_warning inside, see allocator_class->alloc = _gl_mem_alloc)

It think it should be a way to just add the supported memory types to the
query, by adding only the name, not the allocators directly. I found caps
features would be the proper way.

I asked slomo on irc and told me that it is valid to add these allocators to
gst_query_add_allocation_param. But maybe we can revisit this for next
versions.
For sure gstgl add it in the uploader propose_allocation:

allocator = gst_allocator_find (GST_GL_MEMORY_ALLOCATOR);
gst_query_add_allocation_param (query, allocator, &params);

But I cannot find where it is useful. Even if it is I think this could be done
with caps features.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.