[Bug 711155] wayland: add wl_drm support to wayland sink

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=711155

--- Comment #58 from Benjamin Gaignard <benjamin.gaignard at gmail.com> ---
(In reply to Julien Isorce from comment #57)
> I think "gst_query_add_allocation_param" should prevent to add an allocator
> which has its GstAllocatorClass->alloc set to NULL. (which is the case for
> gst dmabuf alocator, it seems that it has derived to also define it with a
> g_warning inside, see allocator_class->alloc = _gl_mem_alloc)
> 
> It think it should be a way to just add the supported memory types to the
> query, by adding only the name, not the allocators directly. I found caps
> features would be the proper way.
> 
> I asked slomo on irc and told me that it is valid to add these allocators to
> gst_query_add_allocation_param. But maybe we can revisit this for next
> versions.
> For sure gstgl add it in the uploader propose_allocation:
> 
> allocator = gst_allocator_find (GST_GL_MEMORY_ALLOCATOR);
> gst_query_add_allocation_param (query, allocator, &params);

Yes before do it like that I have asked the same question (and even when
testing buffer pool and allocator on 0.11 branch) and it is working well so why
change it now ?

> 
> But I cannot find where it is useful. Even if it is I think this could be
> done with caps features.

If you change the caps feature you will have to change lot of plugins.
For example videotestsrc ! waylandsink is functional with dmabuf set as
allocator and this save the copy from shm to hw memory.
It is the same with subtitles, with the implementation I propose we can use
subtitle element (or any other) without modification.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.