[Bug 755251] gtksink: Rework threading around GtkWindow creation

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755251

--- Comment #12 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Matthew Waters from comment #7)
> Review of attachment 312012 [details] [review]:
> 
> ::: ext/gtk/gstgtkbasesink.c
> @@ +90,3 @@
> +
> +static gboolean
> +_invoke_func (struct invoke_context *info)
> 
> This stuff already exists in gtkgstglwidget so you will want to share with
> them

Factored out in a new gstgtkutils.c file

> @@ +258,3 @@
> +      g_value_set_object (value,
> +          _invoke_on_main ((GThreadFunc) gst_gtk_base_sink_get_widget,
> +              gtk_sink));
> 
> This would be extremely prone to deadlocks if called from a thread that
> blocks the main thread in any way.
> 
> Also, performing a round trip to the main thread every g_object_get (obj,
> "widget") is not a great idea.  Cache and locks please with an
> _invoke_on_main() on a cache miss.

Done

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.