[Bug 755251] gtksink: Rework threading around GtkWindow creation

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755251

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312021|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 312021:
 --> (https://bugzilla.gnome.org/review?bug=755251&attachment=312021)

::: ext/gtk/gstgtkbasesink.c
@@ +418,3 @@
+      if (window) {
+        _invoke_on_main ((GThreadFunc) gtk_widget_show_all, window);
+        g_object_unref (window);

What if this was the last reference now? I'd rather unref it in whatever
function you invoke on the main thread.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.