[Bug 755505] ges: trivial leakages

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755505

--- Comment #13 from Justin J. Kim <justin.joy.9to5 at gmail.com> ---
(In reply to Thibault Saunier from comment #11)
> (In reply to Justin J. Kim from comment #9)
> > I thought the lifecycle of object_name_counts variable should be same with
> > timeline-lement because it is defined as static and local variable.
> 
> https://phabricator.freedesktop.org/diffusion/GES/browse/master/ges/ges-
> timeline-element.c;0b900bddc9eb534535e57c42afd27b6fc8d97399$39
> 
> I am not sure what you mean, did I miss something? :)
> 
> It is a bit more complex than that as we keep a counter for each object type
> (name).

Ah. I might choose wrong English word to explain "local". :)
What I want to say is that object_name_count variable is global variable, but
it is created only by timeline-element. Therefore, I was thinking creator
should call destroyer also.

OR, how about to make/define the APIs of this quark container as library?
instead of using it only inside of timeline-element.

I mean, 
rather than calling like this, 
https://phabricator.freedesktop.org/diffusion/GES/browse/master/ges/ges-timeline-element.c;0b900bddc9eb534535e57c42afd27b6fc8d97399$435

using another function like, ges_quark_next_count (q); 


It could be off-topic though, can I use arcanist for my proposed patch?
phabricator looks like more simple than bugzilla to submit patch. :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.