[Bug 755505] ges: trivial leakages

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755505

--- Comment #14 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Justin J. Kim from comment #13)
> (In reply to Thibault Saunier from comment #11)
> > (In reply to Justin J. Kim from comment #9)
> > > I thought the lifecycle of object_name_counts variable should be same with
> > > timeline-lement because it is defined as static and local variable.
> > 
> > https://phabricator.freedesktop.org/diffusion/GES/browse/master/ges/ges-
> > timeline-element.c;0b900bddc9eb534535e57c42afd27b6fc8d97399$39
> > 
> > I am not sure what you mean, did I miss something? :)
> > 
> > It is a bit more complex than that as we keep a counter for each object type
> > (name).
> 
> 
> I mean, 
> rather than calling like this, 
> https://phabricator.freedesktop.org/diffusion/GES/browse/master/ges/ges-
> timeline-element.c;0b900bddc9eb534535e57c42afd27b6fc8d97399$435
> 
> using another function like, ges_quark_next_count (q); 

Sure, would be cleaner (though that naming does not sound right :))

> It could be off-topic though, can I use arcanist for my proposed patch?
> phabricator looks like more simple than bugzilla to submit patch. :)

For GES I have no problem but you should not use it for anything else (the
migration is not done yet, there is nothing official yet, and I am more or less
the only one using it right now)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.