[Bug 743345] glupload: Add support for dmabuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743345

--- Comment #33 from Matthew Waters <ystreet00 at gmail.com> ---
A couple of quick comments from my quick perusal:

- glupload: Implement dmabuf upload
Need to make sure that none of this is actually built when dmabuf is not
available, not just on every EGL && GLES2 implementation.  Add a g_assert()
asserting we don't overrun the attribs array..

- glupload : Use gst_gl_memory_wrapped_texture for dmabuf
Can be squashed into the previous patch after removing the double
glBindTexture.  Also needs to keep track of and destroy the external texture
with the wrapped memory and the EGLImage so probably needs some work on the
lifetimes and possibly GstEGLImageMemory.

- glimagesink: Implement dmabuf display
Again, need to make sure that none of this is actually built when dmabuf is not
available, not just on EGL && GLES2.  Otherwise it looks fine.

- glupload: properly error out if cannot find a method
The first hunk of this is not needed with master.  The rest is just debugging
so can be committed at leisure.

- glupload: Support more color formats in dmabufs caps
Looks good.  Can be squashed as well.

- glmemory: Do not copy GL_TEXTURE_EXTERNAL_OES
Perhaps return NULL; instead of return ret; to be more explicit.  Otherwise,
good.

Yes, glcolorconvert probably needs to learn how to deal with EGLImage's which
effectively means it could be a second glupload for RGBA but that's ok :). 
glcolorconvert can still negotiate passthrough if both sides support EGLImage
and the format is the same, etc.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.