[Bug 743345] glupload: Add support for dmabuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743345

--- Comment #34 from Julien Isorce <julien.isorce at gmail.com> ---
In addition to Matthew remarks:

"Use gst_gl_memory_wrapped_texture"

In comment #29 I maybe was not clear enough but my last thought was it should
use GstEGLImageMemory instead, not gst_gl_memory_wrapped_texture. Sorry it is
extra work but this is the way to go, it is designed for it to properly handle
liftime of the egl image. Also it allows to move all the eglCreateImage+setup
attribs to the file that owns GstEGLImageMemory. See #29.

"glupload dmabuf caps"

Take a look at first part of
https://github.com/CapOM/gst-plugins-bad/commit/80e4293584a398be1a7fd92d2c3221417799b09d.
And second part too. It think it is correct but would require to double check.

"glimagesink: Implement dmabuf display"

A: Feel free to squash
https://github.com/CapOM/gst-plugins-bad/commit/b44122c27b7c52653fedb083888500efefa14b46
in it.
B: I think you can add target param to
gst_gl_shader_compile_with_default_vf_and_check in order to use the right
shader. You can reuse the one in gstglshader.c and add "%s".

"glcolorconvert"
I made it generic:
https://github.com/CapOM/gst-plugins-bad/commit/2d830a2b14d3e003457084f175a8085f2d1ba9be
Though it could be refactored a bit to make the patch less verbose.
It tested for RGBx to RGBA and it works fine for GL_TEXTURE_EXTERNAL_OES.


Good luck Lubosz, I think if you make it use GstEGLImageMemory it will be
candidate for pushing it upstream.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.