[Bug 764631] New: GstAudioDecoder produce invalid timestamps when PLC and delay

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764631

            Bug ID: 764631
           Summary: GstAudioDecoder produce invalid timestamps when PLC
                    and delay
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: fludkov.me at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
                CC: gstreamer at pexip.com
     GNOME version: ---

Created attachment 325414
  --> https://bugzilla.gnome.org/attachment.cgi?id=325414&action=edit
temporary fix+tests

Elements inherited from GstAudioDecoder, supporting PLC and introducing delay
produce invalid timestamps. Good example is opusdec with in-band FEC enabled.
After receiving GAP event it delays the audio concealment until the next buffer
arrives. The next buffer will have DISCONT flag set which will make
GstAudioDecoder to reset it's internal state, thus forgetting the timestamp of
GAP event. As a result the concealed audio will have the timestamp of the next
buffer (with DISCONT flag) but not the timestamp from the event. See
https://bugzilla.gnome.org/show_bug.cgi?id=763058 for the opusdec test case

The patch is what we have in our repo as a workaround for the issue. But it
does not feel as a complete solution, so I suggest to discuss how it can be
fixed properly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.