[Bug 764629] qtdemux: Support sidx based seek in pull mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764629

--- Comment #12 from Seungha Yang <sh.yang at lge.com> ---
(In reply to Sebastian Dröge (slomo) from comment #10)
> Review of attachment 325412 [details] [review]:
> 
> Generally looks good, thanks. Just some remarks
> 
> ::: gst/isomp4/qtdemux.c
> @@ +220,3 @@
>    GstClockTime ts;
>    guint64 moof_offset;
> +  gboolean ref_type;            /* only used for sidx */
> 
> It might be nicer to directly use the GstSidxBox/GstSidxBoxEntries here. We
> might want to use more information from them later, and have them from the
> parser anyway
> 
==> I tried to some ways to use "GstSidxBoxEntries" itself, but there is no
benefit now by using it.... in my opinion. To do that, "GstSidxBoxEntries" and
"QtDemuxRandomAccessEntry" might be decoupled.
Rather than use "GstSidxBoxEntries", I unified parsed sidx box entry with
"QtDemuxRandomAccessEntry" structure. Why don't we consider directly using of
SidxBoxEntries when someone ask to use SidxBoxEntries for the other purpose?

> @@ +2306,3 @@
> +
> +  if (stream->seg_idx_entries)
> +    g_free (stream->seg_idx_entries);
> 
> g_free() is NULL-safe, no need for the "if" here

==> done.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.