[Bug 764947] New: [PATCH] glimagesink: fix "prepare-window-handle" message with autovideosink

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764947

            Bug ID: 764947
           Summary: [PATCH] glimagesink: fix "prepare-window-handle"
                    message with autovideosink
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: jakub.adam at ktknet.cz
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 325789
  --> https://bugzilla.gnome.org/attachment.cgi?id=325789&action=edit
glimagesink: fix "prepare-window-handle" message with autovideosink

GstGLImageSink calls gst_video_overlay_prepare_window_handle() only once on
initialization of its GL context. However, when autovideosink instantiates GL
sink as its actual child sink element, that GL context creation happens while
glimagesink is connected to a dummy GstBus, different from the bus of
autosink's pipeline (see gst_auto_detect_find_best() in GstAutoDetect).

Because application never receives the "prepare-window-handle" element message
posted on dummy bus, it doesn't get a chance to set its own window for video
display and thus glimagesink always creates a new one.

Decoupling window handle assignment from GL context creation in this commit
causes that "prepare-window-handle" message is resent whenever
_ensure_gl_setup() is called with window_id unset, allowing the application to
pick it up once autovideosink connects the glimagesink into its pipeline.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.