[Bug 764947] [PATCH] glimagesink: fix "prepare-window-handle" message with autovideosink

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764947

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325789|none                        |reviewed
             status|                            |

--- Comment #1 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 325789:
 --> (https://bugzilla.gnome.org/review?bug=764947&attachment=325789)

This unfortunately needs careful testing on all platforms to make sure
everything still works.

I'm pretty sure X11, android and possibly wayland are fine with setting the
window handle after context initialization. I'm not entirely sure about the
others.

::: ext/gl/gstglimagesink.c
@@ +825,3 @@
+    gl_sink->window_id = gl_sink->new_window_id;
+    GST_DEBUG_OBJECT (gl_sink, "Setting window handle on gl window");
+    window = gst_gl_context_get_window (gl_sink->context);

You don't unref this anywhere.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.