[Bug 764316] vaapidecode: simplify downstream negotiation
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Apr 14 09:00:43 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=764316
--- Comment #27 from sreerenj <bsreerenj at gmail.com> ---
Review of attachment 325738:
--> (https://bugzilla.gnome.org/review?bug=764316&attachment=325738)
::: gst/vaapi/gstvaapidecode.c
@@ +390,3 @@
+ /* allocation caps changes if cropping differs */
+ alloc_changed = output_width != surface_width
+ || output_height != surface_height;
Are you intended to keep allocation_width/allocation_height zero until there is
resolution change?
if state==NULL && output_width == surface_width && output_height ==
surface_height
then decode->allocation_width = decode->allocation_height = 0
which is misleading...
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list