[Bug 764316] vaapidecode: simplify downstream negotiation

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764316

--- Comment #28 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 325738:
 --> (https://bugzilla.gnome.org/review?bug=764316&attachment=325738)

::: gst/vaapi/gstvaapidecode.c
@@ +390,3 @@
+    /* allocation caps changes if cropping differs */
+    alloc_changed = output_width != surface_width
+        || output_height != surface_height;

if state == NULL and if output size is equal to surface size, then the
allocation size is zero.

Thus, in gst_vaapidecode_update_src_caps() 

  if (decode->allocation_width != 0 || decode->allocation_height != 0) {
      state->allocation_caps = ...

This means that the state allocation caps is not assigned. Later, if in
gstvideodecoder, if allocation_caps is not assigned (NULL) the negotiation caps
are used for allocation query too.

@@ +429,3 @@
   }

+  if (caps_changed || caps_changed) {

d'uh!!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.