[Bug 764707] segment: Modifiy inside segment condition

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764707

--- Comment #6 from Seungha Yang <sh.yang at lge.com> ---
(In reply to Sebastian Dröge (slomo) from comment #4)
> Review of attachment 325516 [details] [review]:
> 
> ::: gst/gstsegment.c
> @@ +887,3 @@
>     * we're outside of the segment */
> +  if (G_UNLIKELY (segment->stop != -1 && start != -1 && (start >
> segment->stop
> +              || (segment->start != segment->stop && start ==
> segment->stop))))
> 
> Can you provide a unit test for this too?

Update test code.

"segment.start == segment.stop" is very rare case, but it actually happen.
Both following cases are inside of segment in my opinion.
Case1: segment_start == segment_stop == start
Case2: segment_start == segment_stop == stop

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.