[Bug 764707] segment: Modifiy inside segment condition

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764707

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326089|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 326089:
 --> (https://bugzilla.gnome.org/review?bug=764707&attachment=326089)

::: tests/check/gst/gstsegment.c
@@ +358,3 @@
+  /* touching boundary point. it's inside because stop at segment start */
+  res = gst_segment_clip (&segment, GST_FORMAT_BYTES,
+      100, 200, &cstart, &cstop);

stop is exclusive, so this should return FALSE

@@ +388,3 @@
+
+  /* start on boundary point */
+  res = gst_segment_clip (&segment, GST_FORMAT_BYTES, 200, -1, &cstart,
&cstop);

Maybe also some with stop!=-1 here?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.