[Bug 760677] basesink: always drops buffers before segment

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760677

--- Comment #11 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #10)
> (In reply to Thiago Sousa Santos from comment #6)
> > A downside is that render will be called for buffers that are late as well
> > and the subclass wouldn't know about it. Perhaps we can add some new api
> > like a drop_frame() method or some function to check if a buffer is late or
> > not from the rendering function.
> 
> Some kind of is_late() function I'd say :)
> 
> 
> Adding flags to caps is an interesting idea, we could also make
> GstVideoInfo/GstAudioInfo add them automatically to cover most cases. The
> question is just how the flags interact with all the caps operations. Do you
> already have some ideas?
> 

Haven't thought deeply about this, my idea is that everything that generates a
new caps loses its flags, pretty much like buffer meta that has to be
'manually' added whenever needed. It could work as simple flags or as GstMeta
like objects depending on the amount of possibilities we want to cover.

>From my POV this would be derived information from a format, for example:

subtitles -> sparse
raw video/audio -> droppable

It should not interfere with negotiation but work as extra hints to elements to
be able to handle data generically.

> 
> 
> A property on basesink would also work for me, it seems like the safe and
> least intrusive option. However having this information generally available
> in the stream somehow seems useful on its own, not just for basesink.

Yes, a property would require going in every sink and updating it depending on
caps. And then you have generic sinks that don't care about formats at all and
wouldn't be able to decide.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.