[Bug 760677] basesink: always drops buffers before segment

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760677

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Thiago Sousa Santos from comment #11)
> (In reply to Sebastian Dröge (slomo) from comment #10)
> > (In reply to Thiago Sousa Santos from comment #6)
> > > A downside is that render will be called for buffers that are late as well
> > > and the subclass wouldn't know about it. Perhaps we can add some new api
> > > like a drop_frame() method or some function to check if a buffer is late or
> > > not from the rendering function.
> > 
> > Some kind of is_late() function I'd say :)
> > 
> > 
> > Adding flags to caps is an interesting idea, we could also make
> > GstVideoInfo/GstAudioInfo add them automatically to cover most cases. The
> > question is just how the flags interact with all the caps operations. Do you
> > already have some ideas?
> > 
> 
> Haven't thought deeply about this, my idea is that everything that generates
> a new caps loses its flags, pretty much like buffer meta that has to be
> 'manually' added whenever needed. It could work as simple flags or as
> GstMeta like objects depending on the amount of possibilities we want to
> cover.

So every caps operation would have the flags disappear in the result? It would
seem difficult to get the flags downstream then without changes to every
element, like with GstMeta.

> It should not interfere with negotiation but work as extra hints to elements
> to be able to handle data generically.

That seems quite ugly in the caps then as it serves a different purpose :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.