[Bug 760677] basesink: always drops buffers before segment

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760677

--- Comment #13 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #12)
> > 
> > Haven't thought deeply about this, my idea is that everything that generates
> > a new caps loses its flags, pretty much like buffer meta that has to be
> > 'manually' added whenever needed. It could work as simple flags or as
> > GstMeta like objects depending on the amount of possibilities we want to
> > cover.
> 
> So every caps operation would have the flags disappear in the result? It
> would seem difficult to get the flags downstream then without changes to
> every element, like with GstMeta.

I don't know how this would work with non-fixed caps. Considering only fixed
caps, elements either just pass the same format or create a new one. For the
later case, I can only think of parsers that would keep the same format, others
(like decoders) are actually transforming the data to a new format and those
flags would need to be updated anyway.

I don't think we can avoid manipulating the flags in some elements anyway. 

> 
> > It should not interfere with negotiation but work as extra hints to elements
> > to be able to handle data generically.
> 
> That seems quite ugly in the caps then as it serves a different purpose :)

I still see this as something similar to buffers' meta. It's like additional
information about a format. Anyway I see that handling those flags across all
caps operations is going to be tricky/confusing. Perhaps it makes more sense to
put that directly in the caps event?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.