[Bug 753751] Dashdemux: returned seekable range for live streams is not usable

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753751

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #332344|none                        |needs-work
             status|                            |

--- Comment #94 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 332344:
 --> (https://bugzilla.gnome.org/review?bug=753751&attachment=332344)

Looks good except for one minor thing

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +2678,3 @@
           uri, stream->last_ret, gst_flow_get_name (stream->last_ret));
+      if (stream->last_ret != GST_FLOW_OK && http_status) {
+        *http_status = stream->last_status_code;

For consistency, this function should *always* set http_status to something
before returning. It's too easy to later forget this in the callers

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.