[Bug 753751] Dashdemux: returned seekable range for live streams is not usable

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Aug 2 06:20:52 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=753751

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #332345|none                        |needs-work
             status|                            |

--- Comment #95 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 332345:
 --> (https://bugzilla.gnome.org/review?bug=753751&attachment=332345)

Seems mostly good now

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +819,3 @@
+          if (details) {
+            gst_structure_get_uint (details, "http-status-code",
+                &stream->last_status_code);

This seems like something that should go together with the other patch (expose
http status code)

@@ +2855,3 @@
+
+  live = gst_adaptive_demux_is_live (demux);
+  if (live) {

Why only for live? It seems like retry for 5xx errors should be done in all
cases, just for non-live you don't want to do the segment skipping

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list