[Bug 770158] element: Add API to more easily post messages about flowing issues

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Aug 22 14:57:27 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=770158

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #333709|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 333709:
 --> (https://bugzilla.gnome.org/review?bug=770158&attachment=333709)

Can you split API and usage in two commits?

Generally looks good to me though, thanks :)

::: gst/gstelement.h
@@ +417,3 @@
+  GST_ELEMENT_ERROR_WITH_DETAILS (el, STREAM, FAILED, \
+      ("Internal data stream error."), \
+      ("streaming stopped, reason %s (%d)", gst_flow_get_name (flow_return),
flow_return), \

These are usually translated, no?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list