[Bug 770678] New: [isomp4/qtdemux] Not considering sample size when calculating size of chunk.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770678

            Bug ID: 770678
           Summary: [isomp4/qtdemux] Not considering sample size when
                    calculating size of chunk.
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: wesfrisby1 at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

The size of chunk is not taking into account the size of samples. Some mp4
files have stream->sample_size != 1. When this occurs they will not play audio.
If stream->sample_size is 1 the current code works. 

What I'm proposing is a change here to lines: 7799/7800

         if (stream->samples_per_frame * stream->bytes_per_frame) {
           cur->size =
-              (stream->samples_per_chunk * stream->n_channels) /
-              stream->samples_per_frame * stream->bytes_per_frame;
+              ((stream->samples_per_chunk * stream->n_channels) /
+              stream->samples_per_frame) * stream->bytes_per_frame *
stream->sample_size;
         } else {
           cur->size = stream->samples_per_chunk;
         }

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.