[Bug 761225] pad: Allow multiple conversion specifiers for request pads and don't require it at the very end

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761225

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #332252|none                        |reviewed
             status|                            |

--- Comment #29 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 332252:
 --> (https://bugzilla.gnome.org/review?bug=761225&attachment=332252)

Generally looks good to me, might just be a little bit too late for 1.10 now.
I'd put it in if others agree though.

::: gst/gstpadtemplate.c
@@ +223,3 @@
  * element.
+ * REQUEST padtemplates can have multiple specifiers in case of %d and %u,
like
+ * src_%u_%u, but %s only can be used once in the template.

%s should also only be allowed at the very end, while the others can also be in
the middle. That's also what the checks for, right?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.