[Bug 775794] qtdemux: can not play xvid/mp2 quicktime format

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775794

--- Comment #5 from Heekyoung Seo <heekyoung.seo at lge.com> ---
Review of attachment 341603:
 --> (https://bugzilla.gnome.org/review?bug=775794&attachment=341603)

I would like to make it separately. I attached new patch for what you've
mentioned. 

+        if (node_length < 86) {
+          GST_WARNING_OBJECT (qtdemux, "%" GST_FOURCC_FORMAT
+              " sample description length too short (%u < 86)",
+              GST_FOURCC_ARGS (fourcc), node_length);
+          break;
+        }
MP4 video sample description length should be bigger than 86, so I make it to
stop parsing node if length is smaller than 86 (not return error and make new
error type), because it is checking on parsing_track fucntion again.

+          str_len = QT_UINT8 (buf);
+          if (str_len < 32)
+            GST_DEBUG_OBJECT (qtdemux, "compressorname = %.*s", str_len,
+                (char *) buf + 1);
+          else
+            GST_WARNING_OBJECT (qtdemux,
+                "compressorname length too big (%u > 31)", str_len);
+
+          buf += 32;            /* the string has a reserved space of 32 bytes
*/
+          buf += 4;             /* 4 bytes reserved */

In my humble opinion, compressor name is not important (that filed is just for
informative purposes on Spec.), therefore I added to check length and leave log
when if it is wrong.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.