[Bug 775794] qtdemux: can not play xvid/mp2 quicktime format

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775794

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #341804|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 341804:
 --> (https://bugzilla.gnome.org/review?bug=775794&attachment=341804)

::: gst/isomp4/qtdemux.c
@@ +7235,3 @@
         /* codec_data is contained inside these atoms, which all have
          * the same format. */
+        if (node_length < 86) {

Why 86?

@@ +7248,1 @@
         if (1 || version == 0x00000000) {

This "if" here looks suspicious. That's always true :)

@@ +7261,3 @@
+
+          buf += 32;            /* the string has a reserved space of 32 bytes
*/
+          buf += 4;             /* 4 bytes reserved */

Compressor name is 32 bytes, that is: 1 byte length, up to 31 bytes string (not
\0-terminated)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.