[Bug 775794] qtdemux: can not play xvid/mp2 quicktime format

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775794

--- Comment #8 from Heekyoung Seo <heekyoung.seo at lge.com> ---
Review of attachment 341804:
 --> (https://bugzilla.gnome.org/review?bug=775794&attachment=341804)

86 is the size of Video Sample Description.

::: gst/isomp4/qtdemux.c
@@ +7235,3 @@
         /* codec_data is contained inside these atoms, which all have
          * the same format. */
+        if (node_length < 86) {

86 is the size of Video Sample Description in Specification. I will make new
patch with mention about it.

@@ +7248,1 @@
         if (1 || version == 0x00000000) {

Yes.. I saw it, too. :) I will fix it.

@@ +7261,3 @@
+
+          buf += 32;            /* the string has a reserved space of 32 bytes
*/
+            GST_DEBUG_OBJECT (qtdemux, "compressorname = %.*s", str_len,

Yes.. It is PASCAL string and reserved 32 bytes total . I mentioned it in upper
comment.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.