[Bug 775794] qtdemux: can not play xvid/mp2 quicktime format

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775794

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Heekyoung Seo from comment #5)
> Review of attachment 341603 [details] [review]:
> 
> I would like to make it separately. I attached new patch for what you've
> mentioned. 
> 
> +        if (node_length < 86) {
> +          GST_WARNING_OBJECT (qtdemux, "%" GST_FOURCC_FORMAT
> +              " sample description length too short (%u < 86)",
> +              GST_FOURCC_ARGS (fourcc), node_length);
> +          break;
> +        }
> MP4 video sample description length should be bigger than 86, so I make it
> to stop parsing node if length is smaller than 86 (not return error and make
> new error type), because it is checking on parsing_track fucntion again.

What about audio/others? Isn't that the same code?

Also even if it is 86 at minimum, whenever we read more than 86 below we need
to check if that much is available.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.