[Bug 776458] urisourcebin: Always configure typefind

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776458

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342441|accepted-commit_now         |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 342441:
 --> (https://bugzilla.gnome.org/review?bug=776458&attachment=342441)

::: gst/playback/gsturisourcebin.c
@@ +1902,3 @@
+    GST_URI_SOURCE_BIN_UNLOCK (urisrc);
+
+    gst_element_no_more_pads (GST_ELEMENT_CAST (urisrc));

no_more_pads() here looks wrong, it's not done in any of the other cases but
instead done "outside"

@@ +2185,3 @@
         G_CALLBACK (source_new_pad), urisrc);
   } else {
+    if (urisrc->is_stream || num_srcpads == 1) {

Why special case 1 srcpad here? The other case should handle 1 srcpad just fine

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.