[Bug 776458] urisourcebin: Always configure typefind

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776458

--- Comment #4 from Seungha Yang <sh.yang at lge.com> ---
(In reply to Sebastian Dröge (slomo) from comment #3)
> Review of attachment 342441 [details] [review]:
> ::: gst/playback/gsturisourcebin.c
> @@ +1902,3 @@
> +    GST_URI_SOURCE_BIN_UNLOCK (urisrc);
> +
> +    gst_element_no_more_pads (GST_ELEMENT_CAST (urisrc));
> 
> no_more_pads() here looks wrong, it's not done in any of the other cases but
> instead done "outside"

It seems that we can remove it, because playbin3 does not connect no-more-pads
signal of urisourcebin. Also, no-more-pads does not posted if a source element
have only sometimes pads.

Do we need no-more-pads signal in playbin3 usecase? Note that decodebin3 also
never post it.

> @@ +2185,3 @@
>          G_CALLBACK (source_new_pad), urisrc);
>    } else {
> +    if (urisrc->is_stream || num_srcpads == 1) {
> 
> Why special case 1 srcpad here? The other case should handle 1 srcpad just
> fine

I'm not sure whether there is an source element which has two static source
pad. (I've never seen it in my usecase). But, for safe reason, I restrict it to
one.

Anyway, I can change it :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.